Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.3-rc-3 #5149

Merged
merged 1 commit into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions build-logic/src/main/kotlin/JapiCmp.kt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

import okhttp3.OkHttpClient
import okhttp3.Request
import org.gradle.api.DefaultTask
Expand Down Expand Up @@ -43,7 +44,8 @@ object JapiCmp {
}

this.artifact = artifact
output.set(File(buildDir, "japicmp/cache/$artifact"))

output.set(File(layout.buildDirectory.asFile.get(), "japicmp/cache/$artifact"))
}

// TODO: Make this lazy
Expand All @@ -62,8 +64,8 @@ object JapiCmp {
packageExcludes = listOf("*.internal*")
onlyModified = true
failOnSourceIncompatibility = false
htmlOutputFile = file("$buildDir/reports/japicmp.html")
txtOutputFile = file("$buildDir/reports/japicmp.txt")
htmlOutputFile = file("${layout.buildDirectory.asFile.get()}/reports/japicmp.html")
txtOutputFile = file("${layout.buildDirectory.asFile.get()}/reports/japicmp.txt")
}
tasks.register("checkJapicmp", me.champeau.gradle.japicmp.JapicmpTask::class.java) {
dependsOn(downloadBaselineJarTaskProvider)
Expand All @@ -73,8 +75,8 @@ object JapiCmp {
packageExcludes = listOf("*.internal*")
onlyModified = true
failOnSourceIncompatibility = true
htmlOutputFile = file("$buildDir/reports/japicmp.html")
txtOutputFile = file("$buildDir/reports/japicmp.txt")
htmlOutputFile = file("${layout.buildDirectory.asFile.get()}/reports/japicmp.html")
txtOutputFile = file("${layout.buildDirectory.asFile.get()}/reports/japicmp.txt")
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import JapiCmp.configureJapiCmp
import java.util.Locale

plugins {
id("apollo.library") apply false
Expand Down Expand Up @@ -102,7 +101,7 @@ tasks.register("ciBuild") {
rootProject.configureDokka()
tasks.named("dokkaHtmlMultiModule").configure {
this as org.jetbrains.dokka.gradle.DokkaMultiModuleTask
outputDirectory.set(buildDir.resolve("dokkaHtml/kdoc"))
outputDirectory.set(layout.buildDirectory.asFile.get().resolve("dokkaHtml/kdoc"))
}

tasks.named("dependencyUpdates").configure {
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-rc-3-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
3 changes: 2 additions & 1 deletion gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ done
# This is normally unused
# shellcheck disable=SC2034
APP_BASE_NAME=${0##*/}
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit

# Use the maximum available, or set MAX_FD != -1 to use that value.
MAX_FD=maximum
Expand Down
2 changes: 1 addition & 1 deletion intellij-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ tasks {
}
}

val mockJdkRoot = buildDir.resolve("mockJDK")
val mockJdkRoot = layout.buildDirectory.asFile.get().resolve("mockJDK")

// Setup fake JDK for maven dependencies to work
// See https://jetbrains-platform.slack.com/archives/CPL5291JP/p1664105522154139 and https://youtrack.jetbrains.com/issue/IJSDK-321
Expand Down
2 changes: 1 addition & 1 deletion libraries/apollo-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ tasks.register("cleanStaleTestProjects") {
/**
* Remove stale testProject directories
*/
val buildFiles = buildDir.listFiles()
val buildFiles = layout.buildDirectory.asFile.get().listFiles()
doFirst {
buildFiles?.forEach {
if (it.isDirectory && it.name.startsWith("testProject")) {
Expand Down
Loading