[IJ plugin] Improve compat->operationBased migration #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
commented
Jul 28, 2023
| @@ -7,7 +7,6 @@ | |||
| </value> | |||
| </option> | |||
| <option name="RIGHT_MARGIN" value="140" /> | |||
| <option name="ENABLE_SECOND_REFORMAT" value="true" /> | |||
There was a problem hiding this comment.
This has been coming back since I switched to IJ 2023.2, LMK if this causes problems.
martinbonnin
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle some more cases, after testing it on https://github.com/HedvigInsurance/android.
It's still not perfect of course (e.g, removed
__typenameare untouched as there's no accurate way to know if they should be removed) but should still save a lot of time/manual work.