Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IJ Plugin] Don't report redefinitions of built-in types as errors #5131

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[IJ Plugin] Don't report redefinitions of built-in types as errors #5131

merged 1 commit into from
Jul 27, 2023

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jul 26, 2023

See JetBrains/js-graphql-intellij-plugin#665
I'll also open a PR to the the GraphQL plugin so hopefully we can remove this from ours.

See also #5126

@BoD BoD requested a review from martinbonnin as a code owner July 26, 2023 18:56
@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 045f249
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64c16c74eb92ca0008645e8c

@martinbonnin martinbonnin mentioned this pull request Jul 27, 2023
Closed
martinbonnin
martinbonnin approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 🎉 . I guess scalar redefinitions are technically errors but doesn't hurt to be a bit lenient here.

@BoD BoD merged commit a3d88bf into main Jul 27, 2023
8 checks passed
@BoD BoD deleted the ij-plugin-suppress-builtin-redefinition-errors branch July 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoD @martinbonnin