Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a AS/IJ plugin doc #5123

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Add a AS/IJ plugin doc #5123

merged 6 commits into from
Aug 2, 2023

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jul 25, 2023

No description provided.

@BoD BoD requested a review from a team as a code owner July 25, 2023 11:24
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for apollo-android-docs ready!

Name Link
🔨 Latest commit 7593eae
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64ca4ae5e3924e00088ee56e
😎 Deploy Preview https://deploy-preview-5123--apollo-android-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but LGTM 🚀

Reading this I was wondering how much of an effort it would be to make a small "tour" screencast video. That would be perfect to showcase the different features here.

ping @Meschreiber, @trevor-scheer @trevorblades do we have that capability in the docs already?

"Mocking HTTP responses": "/testing/mocking-http-responses",
"Mocking GraphQL responses": "/testing/mocking-graphql-responses",
"Data builders": "/testing/data-builders",
"UI Tests": "/testing/ui-tests"
"UI Tests": "/testing/ui-tests",
"Android Studio plugin": "/testing/android-studio-plugin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it up before testing in the list because you should set this up before you start testing. Also update the "Get Started" to link to this page?

docs/source/testing/android-studio-plugin.mdx Outdated Show resolved Hide resolved

#### Kotlin → GraphQL

When editing Kotlin code, <img src="images/gutter-icon.png" alt="Gutter icon" width="16" valign="top"/> icons will show next to references to generated operation and fragment classes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline images do not work :(. I'm no css expert but maybe a display: inline-block; would work here?

Screenshot 2023-07-25 at 13 49 30

docs/source/testing/android-studio-plugin.mdx Outdated Show resolved Hide resolved
@trevor-scheer
Copy link
Member

@martinbonnin I think you meant to tag @trevorblades 😄

@martinbonnin
Copy link
Contributor

Woops wrong Trevor, sorry about this and thanks for the heads up ❤️

@BoD
Copy link
Contributor Author

BoD commented Aug 2, 2023

Added a few videos (as animated webp) that I recycled from the announcement blog post :) I'll merge for now, and we can revisit it later if we can add a 'tour' video!

@BoD BoD merged commit 2e60427 into main Aug 2, 2023
8 checks passed
@BoD BoD deleted the ij-plugin-doc branch August 2, 2023 12:48
@martinbonnin martinbonnin restored the ij-plugin-doc branch August 2, 2023 15:04
martinbonnin added a commit that referenced this pull request Aug 2, 2023
@martinbonnin martinbonnin deleted the ij-plugin-doc branch August 9, 2023 11:20
@martinbonnin martinbonnin restored the ij-plugin-doc branch August 9, 2023 11:20
@martinbonnin martinbonnin deleted the ij-plugin-doc branch August 9, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants