-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a AS/IJ plugin doc #5123
Add a AS/IJ plugin doc #5123
Conversation
✅ Deploy Preview for apollo-android-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but LGTM 🚀
Reading this I was wondering how much of an effort it would be to make a small "tour" screencast video. That would be perfect to showcase the different features here.
ping @Meschreiber, @trevor-scheer @trevorblades do we have that capability in the docs already?
docs/source/config.json
Outdated
"Mocking HTTP responses": "/testing/mocking-http-responses", | ||
"Mocking GraphQL responses": "/testing/mocking-graphql-responses", | ||
"Data builders": "/testing/data-builders", | ||
"UI Tests": "/testing/ui-tests" | ||
"UI Tests": "/testing/ui-tests", | ||
"Android Studio plugin": "/testing/android-studio-plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move it up before testing in the list because you should set this up before you start testing. Also update the "Get Started" to link to this page?
|
||
#### Kotlin → GraphQL | ||
|
||
When editing Kotlin code, <img src="images/gutter-icon.png" alt="Gutter icon" width="16" valign="top"/> icons will show next to references to generated operation and fragment classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Martin Bonnin <[email protected]>
Co-authored-by: Martin Bonnin <[email protected]>
@martinbonnin I think you meant to tag @trevorblades 😄 |
Woops wrong Trevor, sorry about this and thanks for the heads up ❤️ |
Added a few videos (as animated webp) that I recycled from the announcement blog post :) I'll merge for now, and we can revisit it later if we can add a 'tour' video! |
No description provided.