Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apollo stuff outside of apollo ast #5121

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Move apollo stuff outside of apollo ast #5121

merged 2 commits into from
Jul 25, 2023

Conversation

martinbonnin
Copy link
Contributor

Things like key fields and typename additions do not belong in apollo-ast

@martinbonnin martinbonnin requested a review from BoD as a code owner July 24, 2023 14:16
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit e1f1699
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64be90cb35701d0008b13101

@martinbonnin martinbonnin force-pushed the move-apollo-stuff-outside-of-apollo-ast branch from 3adedaa to e1f1699 Compare July 24, 2023 14:55
BoD
BoD approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 170e7ff into main Jul 25, 2023
8 checks passed
@martinbonnin martinbonnin deleted the move-apollo-stuff-outside-of-apollo-ast branch July 25, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD