Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin: make generateSourcesDuringGradleSync opt-in now that we have the IJ plugin #5117

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

martinbonnin
Copy link
Contributor

I've been burned a couple of times where the sync was failing because of bad .graphql files. Feels wrong to have no autocomplete in Gradle files because of some GraphQL files. Plus we have the IJ plugin to do it now.

@martinbonnin martinbonnin requested a review from BoD as a code owner July 24, 2023 08:59
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 4f25386
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64be3d64a15ca900088b98de

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit be4b78a into main Jul 24, 2023
8 checks passed
@martinbonnin martinbonnin deleted the opt-out-codegen-during-sync branch July 24, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants