[IJ plugin] v3 -> v4 migration: Gradle conf #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
|
|
||
| service("service2") { | ||
| packageName.set("com.example.service2") | ||
| dependsOn(project(":schema")) |
There was a problem hiding this comment.
The multi-module + multi-service is a bit weird because before you could have matadata that was used by only one service while now I think it's going to fail if it doesn't find a schema for the given service in the :schema module. There's no way to guess just by looking at the Gradle config of a single project though so this is fine for me 👍
martinbonnin
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service("service") {}blockmapScalarinstead ofcustomScalarsMapping.set/.putapollo/service/dependsOninstead ofdependencies/apolloMetadataAlso add the Migrate actions to Tools / Apollo (in addition to Refactor / Apollo) for increased visibility