More Apollo AST APIs #5104
Merged
More Apollo AST APIs #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
force-pushed
the
more-ast-apis
branch
from
30c6066
to
9345e05
Compare
✅ Deploy Preview for apollo-android-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
String.paseAsGQLDocument(ParserOptions)because there's no need writing everything to utf-8 just to read it back to utf-16 (same forparseAsGQLValue,parseAsGQLType,parseAsGQLSelections)File.parseAsGQLDocument(ParserOptions)because it can populate thefilePathautomaticallyPath.parseAsGQLDocument(ParserOptions)because it can populate thefilePathautomaticallyI didn't add
File.parseAsGQLValue(ParserOptions)and the likes because I don't think it makes much sense to have a file that only contains a value. And it's always easier to add than remove if we need.These APIs are introduced as Stable. The
BufferedSourceequivalent are still experimental because I'm not sure how much we want to commit onBufferedSource(vs kotlinx-io or maybe just exposing String APIs)