Move serialization outside of cache lock

[ashare80]

Lock blocks reads and writes during processing of data before and after accessing cache unnecessarily.

[apollo-cla]

@ashare80: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[netlify]

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	e33a799

[martinbonnin]

Suggested change

	data class CacheDataTransformer<D: Executable.Data>(
	internal class CacheDataTransformer<D: Executable.Data>(

[martinbonnin]

One minor suggestion, LGTM otherwise, Thanks for the contribution!

[BoD]

👍 Thanks!

[BoD]

I missed this before but indeed CacheDataTransformer cannot be internal because now fun <D : Executable.Data> Executable<D>.readDataFromCache() returns it (not caught at build time because we don't track the api in the incubating module).

To keep the return type of readDataFromCache we could:

• add .toData(customScalarAdapters)
• use readInternal instead of readDataFromCache inside readDataFromCacheInternal (it would have to be @ApolloInternal instead of private then)

[martinbonnin]

Thanks again for the contribution! @BoD @ashare80, I pushed a few changes to:

• keep non incubating artifacts in sync
• keep backward compat and use @ApolloInternal to make the symbols we don't want to expose harder to use.

All in all, I think the Executable.readDataFromCache shouldn't have been part of the public API because they're not locking the store. Something to revisit before shipping v4.

Let me know what you think.

[ashare80]

@martinbonnin Awesome thanks!

[BoD]

This looks good to me 👍