Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macrobenchmarks #5100

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add macrobenchmarks #5100

merged 2 commits into from
Jul 18, 2023

Conversation

martinbonnin
Copy link
Contributor

Added benchmark, primarily to see how #5093 behaves.

Using codegen for caching: APK size 987kB

ColdStartupBenchmark_startupNoCompilation
timeToFullDisplayMs   min 290.1,   median 322.8,   max 334.3
timeToInitialDisplayMs   min 200.1,   median 218.6,   max 238.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupFullCompilation
timeToFullDisplayMs   min 225.5,   median 235.1,   max 265.7
timeToInitialDisplayMs   min 172.8,   median 184.0,   max 216.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupBaselineProfile
timeToFullDisplayMs   min 308.7,   median 315.5,   max 355.4
timeToInitialDisplayMs   min 196.2,   median 211.3,   max 232.0
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupBaselineProfileDisabled
timeToFullDisplayMs   min 208.5,   median 226.4,   max 232.8
timeToInitialDisplayMs   min 165.3,   median 174.1,   max 191.4
Traces: Iteration 0 1 2 3 4 5 6 7 8 9

Using apollo-ast for caching: APK size 984kB

ColdStartupBenchmark_startupNoCompilation
timeToFullDisplayMs   min 321.9,   median 340.9,   max 363.1
timeToInitialDisplayMs   min 207.3,   median 209.7,   max 229.9
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupFullCompilation
timeToFullDisplayMs   min 231.4,   median 255.1,   max 276.5
timeToInitialDisplayMs   min 174.9,   median 191.9,   max 212.5
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupBaselineProfile
timeToFullDisplayMs   min 325.3,   median 345.9,   max 369.0
timeToInitialDisplayMs   min 201.3,   median 214.6,   max 236.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
ColdStartupBenchmark_startupBaselineProfileDisabled
timeToFullDisplayMs   min 215.5,   median 238.6,   max 282.7
timeToInitialDisplayMs   min 160.3,   median 170.8,   max 224.3
Traces: Iteration 0 1 2 3 4 5 6 7 8 9

Ultimately looks like it's still worth generating code to help with the cache, esp. since R8 can remove it all if no cache is used. So I'll probably close #5093 but having the macrobenchmarks is still useful.

@martinbonnin martinbonnin requested a review from BoD as a code owner July 17, 2023 18:43
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 61c0224
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64b655acd40d0700078354b3

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinbonnin martinbonnin merged commit 0089ce9 into main Jul 18, 2023
7 of 8 checks passed
@martinbonnin martinbonnin deleted the add-macrobenchmark branch July 18, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants