Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable build scans again #5081

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Enable build scans again #5081

merged 1 commit into from
Jul 10, 2023

Conversation

martinbonnin
Copy link
Contributor

Sorry I got confused about the wording but turns out both are required.

  1. is a Build Scan only and determines whether to publish or not
  2. is Gradle Enterprise only and adds another condition on top of 1.

This reverts commit 775c1d8.

@martinbonnin martinbonnin requested a review from BoD as a code owner July 10, 2023 13:47
@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit e30a458
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64ac0bdcdf17820008c541ca

@martinbonnin martinbonnin merged commit 5747594 into main Jul 10, 2023
7 of 8 checks passed
@martinbonnin martinbonnin deleted the enable-build-scans-again branch July 10, 2023 13:53
@martinbonnin
Copy link
Contributor Author

Merging quickly since it's a revert of a very small patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD Awaiting requested review from BoD BoD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinbonnin