-
Notifications
You must be signed in to change notification settings - Fork 651
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[IJ plugin] v3->v4 migration: add
useV3ExceptionHandling(true)
to `…
…ApolloClient.Builder()`. (#5135)
- Loading branch information
Showing
7 changed files
with
109 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...com/apollographql/ijplugin/refactoring/migration/v3tov4/item/AddUseV3ExceptionHandling.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package com.apollographql.ijplugin.refactoring.migration.v3tov4.item | ||
|
||
import com.apollographql.ijplugin.refactoring.findMethodReferences | ||
import com.apollographql.ijplugin.refactoring.migration.item.MigrationItem | ||
import com.apollographql.ijplugin.refactoring.migration.item.MigrationItemUsageInfo | ||
import com.apollographql.ijplugin.refactoring.migration.item.toMigrationItemUsageInfo | ||
import com.intellij.openapi.project.Project | ||
import com.intellij.psi.PsiMigration | ||
import com.intellij.psi.search.GlobalSearchScope | ||
import org.jetbrains.kotlin.psi.KtPsiFactory | ||
|
||
object AddUseV3ExceptionHandling : MigrationItem() { | ||
override fun findUsages(project: Project, migration: PsiMigration, searchScope: GlobalSearchScope): List<MigrationItemUsageInfo> { | ||
return findMethodReferences( | ||
project = project, | ||
className = "com.apollographql.apollo3.ApolloClient.Builder", | ||
methodName = "Builder", | ||
) | ||
.toMigrationItemUsageInfo() | ||
} | ||
|
||
override fun performRefactoring(project: Project, migration: PsiMigration, usage: MigrationItemUsageInfo) { | ||
val parentExpression = usage.element.parent?.parent ?: return | ||
val replacedExpression = KtPsiFactory(project).createExpression(parentExpression.text.replace("Builder()", "Builder().useV3ExceptionHandling(true)")) | ||
parentExpression.replace(replacedExpression) | ||
} | ||
} |
45 changes: 45 additions & 0 deletions
45
...lin/com/apollographql/ijplugin/refactoring/migration/v3tov4/item/RemoveMethodInService.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
package com.apollographql.ijplugin.refactoring.migration.v3tov4.item | ||
|
||
import com.apollographql.ijplugin.refactoring.migration.item.DeletesElements | ||
import com.apollographql.ijplugin.refactoring.migration.item.MigrationItem | ||
import com.apollographql.ijplugin.refactoring.migration.item.MigrationItemUsageInfo | ||
import com.apollographql.ijplugin.refactoring.migration.item.toMigrationItemUsageInfo | ||
import com.apollographql.ijplugin.util.findPsiFilesByName | ||
import com.apollographql.ijplugin.util.getMethodName | ||
import com.intellij.openapi.project.Project | ||
import com.intellij.psi.PsiMigration | ||
import com.intellij.psi.search.GlobalSearchScope | ||
import org.jetbrains.kotlin.psi.KtCallExpression | ||
import org.jetbrains.kotlin.psi.KtFile | ||
import org.jetbrains.kotlin.psi.KtTreeVisitorVoid | ||
|
||
class RemoveMethodInService( | ||
val methodName: String, | ||
) : MigrationItem(), DeletesElements { | ||
override fun findUsages(project: Project, migration: PsiMigration, searchScope: GlobalSearchScope): List<MigrationItemUsageInfo> { | ||
val usages = mutableListOf<MigrationItemUsageInfo>() | ||
val buildGradleKtsFiles: List<KtFile> = project.findPsiFilesByName("build.gradle.kts", searchScope).filterIsInstance<KtFile>() | ||
for (file in buildGradleKtsFiles) { | ||
file.accept(object : KtTreeVisitorVoid() { | ||
override fun visitCallExpression(expression: KtCallExpression) { | ||
super.visitCallExpression(expression) | ||
if (expression.getMethodName() == "apollo") { | ||
expression.accept(object : KtTreeVisitorVoid() { | ||
override fun visitCallExpression(expression: KtCallExpression) { | ||
super.visitCallExpression(expression) | ||
if (expression.getMethodName() == methodName) { | ||
usages.add(expression.toMigrationItemUsageInfo()) | ||
} | ||
} | ||
}) | ||
} | ||
} | ||
}) | ||
} | ||
return usages | ||
} | ||
|
||
override fun performRefactoring(project: Project, migration: PsiMigration, usage: MigrationItemUsageInfo) { | ||
usage.element.delete() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
intellij-plugin/src/test/testData/migration/v3-to-v4/useV3ExceptionHandling.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.example.myapplication | ||
|
||
import com.apollographql.apollo3.ApolloClient | ||
|
||
suspend fun test() { | ||
val apolloClient: ApolloClient? = ApolloClient.Builder() | ||
.serverUrl("http://localhost") | ||
.build() | ||
} |
9 changes: 9 additions & 0 deletions
9
intellij-plugin/src/test/testData/migration/v3-to-v4/useV3ExceptionHandling_after.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.example.myapplication | ||
|
||
import com.apollographql.apollo3.ApolloClient | ||
|
||
suspend fun test() { | ||
val apolloClient: ApolloClient? = ApolloClient.Builder().useV3ExceptionHandling(true) | ||
.serverUrl("http://localhost") | ||
.build() | ||
} |