[v2] [1/X] ApolloStore async Read/Write lock #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AnthonyMDev
commented
May 15, 2025
| @@ -49,7 +50,7 @@ public class ApolloStore: @unchecked Sendable { | |||
| /// - callbackQueue: The queue to call the completion block on. Defaults to `DispatchQueue.main`. | |||
| /// - completion: [optional] A completion block to be called after records are merged into the cache. | |||
| public func clearCache(callbackQueue: DispatchQueue = .main, completion: ((Result<Void, any Swift.Error>) -> Void)? = nil) { | |||
| queue.async(flags: .barrier) { | |||
| readerWriterLock.write { | |||
There was a problem hiding this comment.
This should have been part of the ApolloStore PR that is stacked on this branch, but accidentally got included here.
This shouldn't matter too much, as that branch will be merged into this before merging this up the stack.
AnthonyMDev
changed the title
|
Going to slowly make our way through these during the week - there is a lot to review. 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a
ReaderWriterusingSwiftAtomicsthat allows for multiple parallel reads while locking for writes.This will replace the current barrier queue for ApolloStore. Usage of this will be implemented in stacked PR.