[In Progress] Apollo iOS 2.0 - Base #645
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was pointing to the JSONValue type which has changed to `any Sendable & Hashable`. This needs to be used as the concrete type for a Set, so it needs to be AnyHashable.
Unit test targets do not yet have strict concurrency turned on.
I’d like to remove these `AnyHashable` casts everywhere, but it would require creating our own JSON wrapper struct that does lazy conversions of values.
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b81ba99b4209b7f1314eb83c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the 2.0 release of Apollo iOS. This is currently in progress and has many stacked PRs that will be merged into it before being ready for release.