[v2] [8/X] Unit Test Overhaul - Part 2 #644
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AnthonyMDev
changed the title
AnthonyMDev
changed the title
AnthonyMDev
force-pushed
the
QueryWatcher-tasklocal-contextid
branch
2 times, most recently
from
26560c8 to
cd8c068
Compare
AnthonyMDev
force-pushed
the
unit-tests-2
branch
2 times, most recently
from
b0d32f0 to
6405384
Compare
AnthonyMDev
force-pushed
the
QueryWatcher-tasklocal-contextid
branch
from
cd8c068 to
3a81cf5
Compare
AnthonyMDev
force-pushed
the
QueryWatcher-tasklocal-contextid
branch
2 times, most recently
from
1ec7c50 to
54a017d
Compare
AnthonyMDev
force-pushed
the
unit-tests-2
branch
3 times, most recently
from
d4d7076 to
7524805
Compare
AnthonyMDev
force-pushed
the
QueryWatcher-tasklocal-contextid
branch
from
54a017d to
531c677
Compare
|
Going to slowly make our way through these during the week - there is a lot to review. 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests are still failing when all tests are run together. I think this is due to async tasks holding up other tasks and causing timeouts. All tests pass when run individually.