fix: Selection set initializer reserved parameter name #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
approved these changes
Feb 5, 2024
calvincestari
deleted the
fix/selection-set-initializer-reserved-parameter-name
branch
BobaFetters
pushed a commit
that referenced
this pull request
Feb 5, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Feb 5, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Feb 5, 2024
c844d744 fix: Selection set initializer reserved parameter name (#257) git-subtree-dir: apollo-ios-codegen git-subtree-split: c844d7448132d0d993a0729512e088ff3b0a661c
BobaFetters
pushed a commit
that referenced
this pull request
Feb 5, 2024
…reserved parameter name git-subtree-dir: apollo-ios-codegen git-subtree-mainline: fb53113 git-subtree-split: c844d7448132d0d993a0729512e088ff3b0a661c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3330.
Adds an underscored alias name to initializer parameters that would conflict with any Swift reserved names. This has only been an issue with
selfspecifically within initializers but this enforces the same behaviour for any of the Swift reserved keywords.