Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update advanced-topics on SSR cache #11956

Closed
wants to merge 1 commit into from

Conversation

smyrick
Copy link
Member

@smyrick smyrick commented Jul 12, 2024

Add docs section on SSR cache

Add section on SSR cache
@smyrick smyrick requested a review from a team as a code owner July 12, 2024 22:49
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: ce11ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit ce11ebd
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6691b2fb777f7b00091ee131
😎 Deploy Preview https://deploy-preview-11956--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas
Copy link
Member

phryneas commented Jul 16, 2024

Hey Shane, thanks for the PR!

For now, we've decided that we want to highlight the existing warnings on SSR page more - see #11960

As for anything beyond that, I'll take this information and will see that I incorporate it more with #11807 - because in that PR we will create a full "SSR" section in the docs. That will probably give these warnings more visibility than adding them to the general-purpose "advanced topics" page.

For that reasons, I'm gonna close this PR - thank you for bringing this up! :)

@phryneas phryneas closed this Jul 16, 2024
@smyrick smyrick deleted the patch-2 branch July 16, 2024 23:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants