Set default hijack option to true
#148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speculating that a change in Docker Desktop 4.10.0 requires that the `Connection` and `Upgrade` headers be sent for stream multiplexing to work. For further detail see moby/moby#43799
|
I'm not sure if changing this default would be a good idea. There's a lot of use cases beside Docker Desktop, I would love more opinions on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on Docker Desktop for ARM Mac 4.11.1 (84025) and I'm experiencing an issue with dockerode, where writing to
stdinnever reaches the process in my container.Based on moby/moby#43799, it seems a change in Docker Desktop 4.10.0 requires that the
ConnectionandUpgradeheaders be sent for stream multiplexing to work, since Docker Desktop proxies the docker socket.