Merge branch 'master' of https://github.com/codefresh-io/docker-modem …

…into fix-memory-leak
apocas · Sep 17, 2024 · 15a8059 · 15a8059
2 parents a9191dd + aadd5d8
commit 15a8059
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 43 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -36,48 +36,14 @@ jobs:
       - name: NPM install
         run: npm install
 
-      - name: Internal Tests
+      - name: NPM test
         run: npm test
 
-      - name: Dockerode Tests
+      - name: Dockerode test suite
         run: |
           cd ../dockerode
           rm -rf ./node_modules/docker-modem
           pwd
           ls ../
           cp -R ../docker-modem ./node_modules/docker-modem
           npm test
-  
-  build_bun:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v3
-      - uses: oven-sh/setup-bun@v1
-
-      - name: Provisioning
-        run: |
-          docker --version
-          bun -v
-          docker pull ubuntu
-          pwd
-          cd ../
-          git clone --depth=50 --branch=master https://github.com/apocas/dockerode.git
-          cd dockerode
-          bun install
-          cd ../docker-modem
-
-      - name: Bun install
-        run: bun install
-
-      - name: Internal Tests
-        run: bun run test
-
-      - name: Dockerode Tests
-        run: |
-          cd ../dockerode
-          rm -rf ./node_modules/docker-modem
-          pwd
-          ls ../
-          cp -R ../docker-modem ./node_modules/docker-modem
-          bun run test
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/modem_test.js b/test/modem_test.js
@@ -70,6 +70,7 @@ describe('Modem', function () {
 
     var modem = new Modem();
     assert.ok(modem.socketPath);
+    assert.strictEqual(modem.host, undefined);
     assert.strictEqual(modem.socketPath, '/tmp/docker.sock');
   });