Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect back to form after adding or removing deviations #1334

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Mikael-Lenander
Copy link
Contributor

Description

What?

After adding or removing a deadline or submission deviation through the form, redirects back to the form instead of redirecting to the deviation list page.

Why?

The deviation lists load very slowly, especially in courses with many deviations like Programming 1. This is just a way to avoid visiting the deviation page. This mainly concerns the deadline deviation list but I added the same modifications to submission deviations as well for consistency.

How?

Changes the success urls of views.

Fixes #1122 (partly)

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Added, overrode and removed deadline and submission deviations through the web interface.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and seems to work. Nice!

@ihalaij1 ihalaij1 merged commit 0424b42 into apluslms:master Feb 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bypass (or improve) the slow-loading DL deviations page
2 participants