Optimize inefficient database query in the deviation list view #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds very promising! |
PasiSa
reviewed
Nov 10, 2023
| ) | ||
| # parent is prefetched because there may be multiple ancestors, and | ||
| # they are needed for building the deviation's URL. | ||
| .defer( |
There was a problem hiding this comment.
Minor nit: I think the defer call should be before the comment above, that refers to prefetch_related.
markkuriekkinen
approved these changes
Nov 10, 2023
| ) | ||
| # parent is prefetched because there may be multiple ancestors, and | ||
| # they are needed for building the deviation's URL. | ||
| .defer( |
The course module name is no longer queried separately for each deviation. This reduces the number of performed queries significantly. Additionally, some large unnecessary attributes are no longer loaded. Fixes apluslms#1302
ihalaij1
force-pushed
the
fix-deviations
branch
from
4ea7eb4
to
95ed629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
The course module name is no longer queried separately for each deviation. This reduces the number of performed queries significantly. Additionally, some large unnecessary attributes are no longer loaded.
Why?
The deviations list page loaded extremely slowly before. This should help with the problem.
Fixes #1302