Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircraft endpoint, integration test fix #480

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Aircraft endpoint, integration test fix #480

wants to merge 21 commits into from

Conversation

valentinoli
Copy link

Fix to integration test

@MiniGod MiniGod mentioned this pull request Feb 4, 2019
@MiniGod
Copy link
Member

MiniGod commented Feb 5, 2019

I took a quick look at it. You were simply misconfiguring nock, and missing the fixture for the "flight not found" test. nock can be a bit hard to grasp. Please look at the commit I did.

fyi, you can run npm run test locally, and you should get the same errors. No need to push to GitHub to test. We'll probably squash merge this. That way it will just be one commit and the number of commits wont be an issue :)

@valentinoli
Copy link
Author

valentinoli commented Feb 7, 2019

Thanks for taking a look! I have never used nock before but understand it better now. I tried running npm run test locally but it wasn't working for some reason Uncaught Error: connect ECONNREFUSED 127.0.0.1:3101 Sorry about all the commits! What is the next step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants