Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Proxy Endpoint Unifier #687

Merged
merged 21 commits into from
Aug 16, 2023
Merged

Adding Proxy Endpoint Unifier #687

merged 21 commits into from
Aug 16, 2023

Conversation

anaik91
Copy link
Contributor

@anaik91 anaik91 commented Aug 14, 2023 •
edited
Loading

Description

Apigee X has a limitation of hosting only 5 Proxy Endpoints per proxy.
Apigee OPDK /Edge has no such limitation.
Objective is take a proxy bundle and smartly convert them into conditional flows and group them with other proxy endpoints.

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

@google-cla
Copy link

google-cla bot commented Aug 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OmidTahouri OmidTahouri self-assigned this Aug 14, 2023
@anaik91
Copy link
Contributor Author

anaik91 commented Aug 14, 2023

/gcbrun

1 similar comment
@danistrebel
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier fail 0s
TOTAL PIPELINE pass 0s

View details in Cloud Build (permission required)

Commit version: 655e5af

@anaik91
Copy link
Contributor Author

anaik91 commented Aug 15, 2023

@danistrebel @OmidTahouri : kindly run gcbrun when you get a chance

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/proxy-endpoint-unifier fail 0s
TOTAL PIPELINE pass 0s

View details in Cloud Build (permission required)

Commit version: cbae732

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 5s
TOTAL PIPELINE pass 5s

View details in Cloud Build (permission required)

Commit version: 795f140

OmidTahouri
OmidTahouri requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

tools/proxy-endpoint-unifier/README.md Show resolved Hide resolved
tools/proxy-endpoint-unifier/main.py Show resolved Hide resolved
tools/proxy-endpoint-unifier/pipeline.sh Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/manifests/manifest.xml Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/policies/Populate-Cache-1.xml Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/policies/Populate-Cache-1.xml Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/proxies/ProxyEndpoint-1.xml Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/targets/default.xml Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/test-proxy.xml Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier fail 3s
TOTAL PIPELINE pass 3s

View details in Cloud Build (permission required)

Commit version: 5f92893

OmidTahouri
OmidTahouri requested changes Aug 16, 2023
View reviewed changes
tools/proxy-endpoint-unifier/main.py Show resolved Hide resolved
tools/proxy-endpoint-unifier/main.py Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/pipeline.sh Show resolved Hide resolved
tools/proxy-endpoint-unifier/pipeline.sh Outdated Show resolved Hide resolved
tools/proxy-endpoint-unifier/utils.py Show resolved Hide resolved
tools/proxy-endpoint-unifier/xorhybrid.py Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 3s
TOTAL PIPELINE pass 3s

View details in Cloud Build (permission required)

Commit version: d2db718

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 5s
TOTAL PIPELINE pass 5s

View details in Cloud Build (permission required)

Commit version: ecf4b51

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 4s
TOTAL PIPELINE pass 4s

View details in Cloud Build (permission required)

Commit version: d80c5b4

OmidTahouri
OmidTahouri approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 4s
TOTAL PIPELINE pass 5s

View details in Cloud Build (permission required)

Commit version: 5d4f039

danistrebel
danistrebel approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@danistrebel danistrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we can remove the copyright note on the README, that would be perfect.

tools/proxy-endpoint-unifier/README.md Outdated
## Limitations
* This tool does not currently handle the resources within API proxies.

## Copyright
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this as the solution inherits the license from the repo level?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@OmidTahouri
Copy link
Collaborator

/gcbrun

OmidTahouri
OmidTahouri approved these changes Aug 16, 2023
View reviewed changes
tools/proxy-endpoint-unifier/README.md Outdated
## Limitations
* This tool does not currently handle the resources within API proxies.

## Copyright
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier fail 4s
TOTAL PIPELINE pass 4s

View details in Cloud Build (permission required)

Commit version: fd3ba09

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/pipeline-runner pass 0s
tools/proxy-endpoint-unifier pass 4s
TOTAL PIPELINE pass 4s

View details in Cloud Build (permission required)

Commit version: af3e94e

@OmidTahouri OmidTahouri merged commit 6d68fa3 into apigee:main Aug 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmidTahouri OmidTahouri OmidTahouri approved these changes

@danistrebel danistrebel danistrebel approved these changes

@seymen seymen Awaiting requested review from seymen seymen is a code owner

Assignees

@OmidTahouri OmidTahouri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anaik91 @danistrebel @apigee-devrel-bot @OmidTahouri