-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Proxy Endpoint Unifier #687
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
1 similar comment
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 655e5af |
@danistrebel @OmidTahouri : kindly run gcbrun when you get a chance |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: cbae732 |
fix: changes to proxy endpoint unifier readme
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 795f140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/manifests/manifest.xml
Outdated
Show resolved
Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/policies/Populate-Cache-1.xml
Outdated
Show resolved
Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/policies/Populate-Cache-1.xml
Outdated
Show resolved
Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/proxies/ProxyEndpoint-1.xml
Show resolved
Hide resolved
tools/proxy-endpoint-unifier/test/api_bundles/apiproxy/targets/default.xml
Outdated
Show resolved
Hide resolved
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 5f92893 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: d2db718 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: ecf4b51 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: d80c5b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: 5d4f039 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if we can remove the copyright note on the README, that would be perfect.
## Limitations | ||
* This tool does not currently handle the resources within API proxies. | ||
|
||
## Copyright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this as the solution inherits the license from the repo level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/gcbrun |
## Limitations | ||
* This tool does not currently handle the resources within API proxies. | ||
|
||
## Copyright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Pipeline Report
View details in Cloud Build (permission required) Commit version: fd3ba09 |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: af3e94e |
Description
Apigee X has a limitation of hosting only 5 Proxy Endpoints per proxy.
Apigee OPDK /Edge has no such limitation.
Objective is take a proxy bundle and smartly convert them into conditional flows and group them with other proxy endpoints.
Housekeeping
(please check all that apply [x], do not edit the text)
Full Repo Validation Required
(please check all that apply [x], do not edit the text)
CC: @apigee-devrel-reviewers