fix: quick fix handling invoke message #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds thread safety. With a lot of threads, the id was generated in not thread safe manner the id generation was moved under the mutex - it is the only place where it is generated. This way it is unique now.
dorotaphanSiili
changed the title
dorotaphanSiili
force-pushed
the
dphan/thread-safety-invoke-message
branch
4 times, most recently
from
6a6fffb to
8e902e0
Compare
the unsigned type suites better the request id type, id should not be negative. Fixes the overflow issue, as unsigned int behavior is defined.
dorotaphanSiili
force-pushed
the
dphan/thread-safety-invoke-message
branch
from
8e902e0 to
b80f4f8
Compare
w4bremer
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds thread safety.
With a lot of threads, the id was generated in not thread safe manner the id generation was moved under the mutex - it is the only place where it is generated. This way it is unique now.
Closes apigear-io/performance-checks#24 for cpp
📑 Description
✅ Checks
ℹ Additional Information