Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling in CLI and templates documentation #273

Merged
merged 9 commits into from
Jul 8, 2024
Merged

fix: error handling in CLI and templates documentation #273

merged 9 commits into from
Jul 8, 2024

Conversation

vdusek
Copy link
Collaborator

@vdusek vdusek commented Jul 8, 2024 •
edited
Loading

Description

  • Rename local_storage_dir to storage_dir.
  • Mention templates and CLI in readme.
  • Mention templates and CLI in doc
  • Fix CLI when project directory already exists.
  • Handle CTRL+C in CLI.
  • Poetry templates to Pip templates.

Issues

Testing

  • All scenarios were executed locally. Handling CTRL+C is still not perfect. However, this should be ok for the initial release.

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@github-actions github-actions bot added this to the 93rd sprint - Tooling team milestone Jul 8, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jul 8, 2024
github-actions[bot]
github-actions bot reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 8, 2024
B4nan
B4nan reviewed Jul 8, 2024
View reviewed changes
src/crawlee/configuration.py Outdated Show resolved Hide resolved
@vdusek vdusek changed the title fix: CLI templates fix: error handling in CLI and templates documentation Jul 8, 2024
@vdusek vdusek requested a review from B4nan July 8, 2024 12:09
@vdusek vdusek marked this pull request as ready for review July 8, 2024 12:11
@vdusek vdusek requested a review from B4nan July 8, 2024 12:44
@vdusek vdusek merged commit 61083c3 into master Jul 8, 2024
20 checks passed
@vdusek vdusek deleted the fix-templates branch July 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@B4nan B4nan Awaiting requested review from B4nan

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
93rd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

CRAWLEE_LOCAL_STORAGE_DIR should be called just CRAWLEE_STORAGE_DIR
2 participants
@vdusek @B4nan