Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using apify-shared for general consts and utils #132

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Start using apify-shared for general consts and utils #132

merged 8 commits into from
Jul 28, 2023

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Jul 25, 2023

Closes #131

@vdusek vdusek requested a review from fnesveda July 25, 2023 13:24
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 25, 2023
jirimoravcik
jirimoravcik requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

pyproject.toml Outdated Show resolved Hide resolved
src/apify_client/clients/resource_clients/actor_collection.py Outdated Show resolved Hide resolved
fnesveda
fnesveda requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some comments about the consts. And in the end I agree with Jirka's point about ListPage, sorry for originally saying that it shouldn't be moved, that was wrong.

docs/res/sphinx-config/index.rst Show resolved Hide resolved
src/apify_client/consts.py Show resolved Hide resolved
fnesveda
fnesveda requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing about the deprecation warnings in consts.py

src/apify_client/consts.py Outdated Show resolved Hide resolved
fnesveda
fnesveda requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments still

src/apify_client/consts.py Outdated Show resolved Hide resolved
src/apify_client/consts.py Outdated Show resolved Hide resolved
@vdusek vdusek requested a review from fnesveda July 28, 2023 09:28
fnesveda
fnesveda approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@vdusek vdusek merged commit 98c77cd into master Jul 28, 2023
18 checks passed
@vdusek vdusek deleted the add-apify-shared branch July 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

@vdusek vdusek

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start using apify-shared for general consts and utils
3 participants
@vdusek @jirimoravcik @fnesveda