feat: add list_and_lock_head, delete_request_lock, prolong_request_lock, batch_add_requests, batch_delete_requests and list_requests methods #129
Conversation
github-actions
bot
added
t-platform
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
I'd extend the tests, e.g. lock the requests for 10 seconds, then wait ~11 seconds and check if they were unlocked or something like that. Or maybe we'll do more extensive testing in the SDK so it's ok to have less tests here. We'll see what @fnesveda thinks.
There was a problem hiding this comment.
Nice! I like that you made integration tests for this, I'm sad that we don't have them for the rest of the client 😄 I just had some notes mostly to the docstrings.
And regarding Jirka's point - I'm not sure how complicated the tests need to be here, all the aspects of the platform features should be tested by the platform integration tests, not the client tests, so I think it's fine to just check if the API endpoints work and return what they should, without too many complicated tests.
Co-authored-by: František Nesveda <[email protected]>
how about we automate this going forward? |
I kind of like the versioning flexibility this gives us, plus we weren't making that many changes to these libraries for it to be worth investing the time into. But maybe there is some easy solution for this. |
fnesveda
modified the milestones:
67th sprint - Platform team,
68th sprint - Platform team
Co-authored-by: František Nesveda <[email protected]>
drobnikj
changed the title
fnesveda
added
the
validated
Python code after a long time, rather check it carefully. 😄