[BREAKING] renamings #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gullmar
reviewed
Feb 27, 2025
README.md
Outdated
| persistSupport: 'kvs', // will enable persistence-related features, such as managing resurrections | ||
| persistEncryptionKey: 'my-secret-key', // will make data written by the Orchestrator into the Key Value Store encrypted | ||
| persisntanceEncryptionKey: 'my-secret-key', // will make data written by the Orchestrator into the Key Value Store encrypted |
There was a problem hiding this comment.
There is a typo: persisntance → persistence.
Since we are breaking changing, wouldn't it be better to change the persistSupport parameter, too?
|
I guess this should not go into main, but when we think it's ready I create a |
We don't want to persist the encryption key, we want to recieve the encryption key used for persistance
gullmar
force-pushed
the
breaking-change-wording
branch
from
ae0d785 to
e1c68a8
Compare
gullmar
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.