This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Better and simpler Python example #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims of these changes are: - simplify the example - introduce the requests library http://docs.python-requests.org/, which is ubiquitous in Python ecosystem these days - introduce Python2/Python3 compatibility (tested on both) - fix minor issues with formatting and indentation - remove unnecessary conversions of body payload according to Content-Type - we already get it as string, we can use it directly as string I suppose This proposal should supersede both https://github.com/apiaryio/language-templates/tree/python-requests and https://github.com/apiaryio/language-templates/tree/python3 branches. It should also fix #5.
|
@honzajavorek Internal note: is there an example for v3 as well? |
| values = dumps(<%= @body %>) | ||
| <% else if @method isnt 'GET' and @body: %> | ||
| values = <%= @helpers.escape @body %> | ||
| <pre class="incoming"><code class="language-python">from __future__ import print_function |
There was a problem hiding this comment.
Since we're not passing in any parameters other than the first parameter, there is no need to do from __future__ import print_function. It will only become a tuple if there is a trailing , inside the parenthesis.
$ python2.6
>>> print('example')
example
>>> print('example', 'item')
('example', 'item')There was a problem hiding this comment.
👍 good point! knew that, but did not realize this fact can simplify the example
|
Closing until @honzajavorek gets back to it. Can reopen then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims of these changes are:
This proposal should supersede both https://github.com/apiaryio/language-templates/tree/python-requests and https://github.com/apiaryio/language-templates/tree/python3 branches. It should also fix #5.
Also fixes https://trello.com/c/Zp06pT75/133-strange-indentation-in-python-examples-in-new-docs (internal).
cc @Almad