Skip to content
This repository has been archived by the owner on Jul 2, 2019. It is now read-only.

Update to json-schema-faker 0.5.0-rc16 #222

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Update to json-schema-faker 0.5.0-rc16 #222

merged 2 commits into from
Nov 16, 2018

Conversation

kylef
Copy link
Member

@kylef kylef commented Nov 8, 2018 •
edited
Loading

Notable changes:

  • fixedProbabilities: true + optionalsProbability: 1.0 is equivilent to the existing behaviour of alwaysFakeOptionals.
  • Calling the module is deprecated, now you have to call the generate method.
  • Faker now mutates the given schema and does dereferencing. Creating a deep copy to prevent that from happening.

Closes #168

@kylef kylef requested a review from honzajavorek November 8, 2018 20:20
@pksunkara pksunkara merged commit d6ab86c into master Nov 16, 2018
@pksunkara pksunkara deleted the kylef/faker branch November 16, 2018 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@honzajavorek honzajavorek honzajavorek approved these changes

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylef @pksunkara @honzajavorek