Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lua_error_log_request_id command to append request_id #93

Merged
merged 12 commits into from
Dec 4, 2024
Merged

feat: add lua_error_log_request_id command to append request_id #93

merged 12 commits into from
Dec 4, 2024

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Dec 2, 2024 •
edited
Loading

Screenshot from 2024-12-02 17-24-16
Screenshot from 2024-12-02 17-23-54

@Revolyssup Revolyssup marked this pull request as draft December 2, 2024 10:12
@Revolyssup Revolyssup marked this pull request as ready for review December 2, 2024 11:55
@Revolyssup Revolyssup changed the title feat: add log handler module to append request_id feat: add log handler command to append request_id Dec 2, 2024
@Revolyssup Revolyssup changed the title feat: add log handler command to append request_id feat: add apisix_request_id_var command to append request_id Dec 2, 2024
nic-6443
nic-6443 reviewed Dec 3, 2024
View reviewed changes
t/request-id-err-log.t Outdated Show resolved Hide resolved
@Revolyssup Revolyssup changed the title feat: add apisix_request_id_var command to append request_id feat: add lua_error_log_request_id command to append request_id Dec 3, 2024
membphis
membphis reviewed Dec 3, 2024
View reviewed changes
t/request-id-err-log.t Outdated

__DATA__

=== TEST 1: request_id in error log set
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use apisix_request_id here, we mainly use this name later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please review again

membphis
membphis approved these changes Dec 4, 2024
View reviewed changes
Copy link

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@membphis
Copy link

membphis commented Dec 4, 2024

CI failed

image

@Revolyssup
Copy link
Contributor Author

CI failed

image

This is because this repository no longer exists on which this CI depends

apisix-nginx-module/.github/workflows/gm.yml

Line 34 in cdee98e

git clone https://github.com/api7/tongsuo --depth 1

Maybe I can remove/fix this in other PR.

@Revolyssup Revolyssup merged commit 22cbc7d into main Dec 4, 2024
3 of 4 checks passed
@nic-6443 nic-6443 deleted the revolyssup/custom-err-handler branch December 4, 2024 06:47
@Revolyssup Revolyssup mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-6443 nic-6443 nic-6443 approved these changes

@membphis membphis membphis approved these changes

@moonming moonming Awaiting requested review from moonming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revolyssup @membphis @nic-6443