-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: deprecate openldap dependency for apisix #337
base: master
Are you sure you want to change the base?
Conversation
Please make the ci pass |
Please correct me if I am wrong but it seems like a circular dependency happened between #337 and apache/apisix#10176
|
@Zhenye-Na Please fix the CI errors first. |
As I mentioend above, the circular dependency of this repo and apache/apisix occurs here: https://github.com/api7/apisix-build-tools/actions/runs/6445185009/workflow?pr=337#L44 this package is building apisix with the master branch, where lualdap/openldap exists. However, this PR delted the dependency which caused the issue. If it is ok to you @kingluo , I could redirect the line above to my own forked branch to see if CI could pass. |
@Zhenye-Na |
Please let me know what else I could test to make sure there is nothing I missed regarding this dependency deprecation. Meanwhile, if there is a way to inject my personal fork to test things out here, that will be even better. Thanks! |
@Zhenye-Na Is this PR prerequisite for apache/apisix#10176? |
@Zhenye-Na Can you fix the merge conflicts? |
Yes |
I could work on this, but will definitely appreciate any guidance of merging this PR later |
When can you work on this? |
Please allow me to rebase and resolve any merge conflicts by end of this Friday. I could ping you here once I got next revision out, if it works for you ? thanks |
Missed the committed SLA, will prioritize this patch during this work week. Thanks |
@Revolyssup just resolved merge conflicts |
This PR is in the scope of this issue in apisix repo: apache/apisix#7865