Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: deprecate openldap dependency for apisix #337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zhenye-Na
Copy link

This PR is in the scope of this issue in apisix repo: apache/apisix#7865

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

@Zhenye-Na Zhenye-Na marked this pull request as ready for review October 8, 2023 03:12
@monkeyDluffy6017
Copy link
Contributor

Please make the ci pass

@Zhenye-Na
Copy link
Author

Zhenye-Na commented Oct 8, 2023

Please make the ci pass

Please correct me if I am wrong but it seems like a circular dependency happened between #337 and apache/apisix#10176

  1. This PR pulls latest of apisix where openldap is in the rockspec
  2. fix: remove openldap dependencies from apisix apache/apisix#10176 depends on the build tool change in this PR

@kingluo
Copy link

kingluo commented Oct 8, 2023

@Zhenye-Na Please fix the CI errors first.

@Zhenye-Na
Copy link
Author

As I mentioend above, the circular dependency of this repo and apache/apisix occurs here: https://github.com/api7/apisix-build-tools/actions/runs/6445185009/workflow?pr=337#L44

this package is building apisix with the master branch, where lualdap/openldap exists. However, this PR delted the dependency which caused the issue.

If it is ok to you @kingluo , I could redirect the line above to my own forked branch to see if CI could pass.

@kingluo
Copy link

kingluo commented Oct 9, 2023

@Zhenye-Na
ok, if you confirm these 4 errors are expected due to circular dependencies (I think so after reading the code), I'll approve it.
@monkeyDluffy6017 @membphis @moonming
What about your opinions?

@Zhenye-Na
Copy link
Author

@Zhenye-Na ok, if you confirm these 4 errors are expected due to circular dependencies (I think so after reading the code), I'll approve it. @monkeyDluffy6017 @membphis @moonming What about your opinions?

Please let me know what else I could test to make sure there is nothing I missed regarding this dependency deprecation. Meanwhile, if there is a way to inject my personal fork to test things out here, that will be even better.

Thanks!

@Revolyssup
Copy link
Collaborator

@Zhenye-Na Is this PR prerequisite for apache/apisix#10176?

@Revolyssup
Copy link
Collaborator

@Zhenye-Na Can you fix the merge conflicts?

@Zhenye-Na
Copy link
Author

@Zhenye-Na Is this PR prerequisite for apache/apisix#10176?

Yes

@Zhenye-Na
Copy link
Author

@Zhenye-Na Can you fix the merge conflicts?

I could work on this, but will definitely appreciate any guidance of merging this PR later

@Revolyssup
Copy link
Collaborator

@Zhenye-Na Can you fix the merge conflicts?

I could work on this, but will definitely appreciate any guidance of merging this PR later

When can you work on this?

@Zhenye-Na
Copy link
Author

@Zhenye-Na Can you fix the merge conflicts?

I could work on this, but will definitely appreciate any guidance of merging this PR later

When can you work on this?

Please allow me to rebase and resolve any merge conflicts by end of this Friday.

I could ping you here once I got next revision out, if it works for you ?

thanks

@Zhenye-Na
Copy link
Author

Missed the committed SLA, will prioritize this patch during this work week.

Thanks

@Zhenye-Na
Copy link
Author

@Revolyssup just resolved merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants