-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update apisix-base to cross-compile on minideb #154
Open
bzp2010
wants to merge
8
commits into
api7:master
Choose a base branch
from
bzp2010:feat-apisix-base-cross
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bzp2010
commented
Jan 13, 2022
- change base image to minideb "bullseye - 11" (The bitnami‘s image is usually used in a debian-based cropped version)
- nearly 50x speedup by using of full cross-compilation
tzssangglass
approved these changes
Jan 13, 2022
spacewander
reviewed
Jan 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need it yet
soulbird
reviewed
Jun 7, 2022
@@ -88,6 +88,8 @@ cd apisix-nginx-module/patch || exit 1 | |||
cd ../.. | |||
|
|||
cd wasm-nginx-module || exit 1 | |||
if [ -z $TARGETARCH ] ; then export TARGETARCH="amd64"; fi | |||
if [ "$TARGETARCH" = "arm64" ] ; then sed -i 's/x86_64/aarch64/g' ./install-wasmtime.sh; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasm support build for arm64: https://github.com/api7/wasm-nginx-module/blob/main/install-wasmtime.sh#L17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.