symfony ^6.3 || 7 #6007
Closed
symfony ^6.3 || 7 #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I see that CI has failed with lots of issues, most relatively small, but I think the complicated part is backwards compatibility (which is why I bumped the requirements to 6.3, since Symfony hasn't necessarily made the signature changes to unsupported versions). |
* Revert "Revert "fix: missing eager joins on to-one relationships (api-platform#5992)"" This reverts commit dac49cb. * test: fix related dummies related tests * test: duplicate changes in mongoDB documents
|
I took your commit at #6009 not sure why we would bump to 6.3 I want to see the ci running like this to see if there are things we need to fix |
Symfony 7 adds a new parameter `$buildDir` to `WarmableInterface::warmUp()`, so that the method signature of `CachePoolClearerCacheWarmer::warmUp()` needs to be updated.
|
mhh weird sorry I pushed on your upstream I didn't wanted to, we'll continue in my PR thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply allows Symfony 7 to be installed, but there may be an issue with phpspec