-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Email SignIn #98
Conversation
…apeun-gidaechi/seugi-android into feature/94-create-email-sign-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
직접적인 data module은 존재하지 않고, 자식들을 감싸는 패키지의 형태로서만 존재해야합니다.
수정부탁드릴게요.
|
||
@Binds | ||
fun provideEmailSignInRepository(emailSignInRepositoryImpl: EmailSignInRepositoryImpl): EmailSignInRepository | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
싱글톤을 사용해주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하하 깜박했네요
internal fun MainScreen(navHostController: NavHostController = rememberNavController()) { | ||
fun MainScreen(navHostController: NavHostController = rememberNavController()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal을 삭제하신 이유가 있으실까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 제가 네비게이션 문제를 해결하다 삭제가 된거 같습니다.
방법을 찾았고 접근제한자를 다시 추가하였습니다.
internal fun OnboardingScreen(navHostController: NavHostController = rememberNavController()) { | ||
fun OnboardingScreen(navHostController: NavHostController = rememberNavController(), onboardingToMain: () -> Unit) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마찬가지 입니다.
@SeugiDispatcher(DispatcherType.IO) private val dispatcher: CoroutineDispatcher, | ||
private val httpClient: HttpClient, | ||
) : EmailSignInDatasource { | ||
override suspend fun emailSignIn(body: EmailSignInRequest): BaseResponse<EmailSignInResponse> = httpClient.post("${SeugiUrl.Auth.EMAIL_SIGN_IN}") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
따옴표로 감싸지 않아도 될 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옳은 말씀이십니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
No description provided.