Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Email SignIn #98

Merged
merged 30 commits into from
Jun 12, 2024
Merged

Feature/Email SignIn #98

merged 30 commits into from
Jun 12, 2024

Conversation

wnsgur1
Copy link
Collaborator

@wnsgur1 wnsgur1 commented May 21, 2024

No description provided.

@wnsgur1 wnsgur1 self-assigned this May 21, 2024
@wnsgur1 wnsgur1 requested a review from 8954sood May 21, 2024 09:17
@wnsgur1 wnsgur1 added the Feature 새로운 기능 개발 label May 21, 2024
@wnsgur1 wnsgur1 linked an issue May 21, 2024 that may be closed by this pull request
Copy link
Member

@8954sood 8954sood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접적인 data module은 존재하지 않고, 자식들을 감싸는 패키지의 형태로서만 존재해야합니다.
수정부탁드릴게요.

Comment on lines 13 to 16

@Binds
fun provideEmailSignInRepository(emailSignInRepositoryImpl: EmailSignInRepositoryImpl): EmailSignInRepository
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싱글톤을 사용해주세요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하하 깜박했네요

internal fun MainScreen(navHostController: NavHostController = rememberNavController()) {
fun MainScreen(navHostController: NavHostController = rememberNavController()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal을 삭제하신 이유가 있으실까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 제가 네비게이션 문제를 해결하다 삭제가 된거 같습니다.
방법을 찾았고 접근제한자를 다시 추가하였습니다.

internal fun OnboardingScreen(navHostController: NavHostController = rememberNavController()) {
fun OnboardingScreen(navHostController: NavHostController = rememberNavController(), onboardingToMain: () -> Unit) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지 입니다.

@SeugiDispatcher(DispatcherType.IO) private val dispatcher: CoroutineDispatcher,
private val httpClient: HttpClient,
) : EmailSignInDatasource {
override suspend fun emailSignIn(body: EmailSignInRequest): BaseResponse<EmailSignInResponse> = httpClient.post("${SeugiUrl.Auth.EMAIL_SIGN_IN}") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따옴표로 감싸지 않아도 될 것 같습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옳은 말씀이십니다.

@wnsgur1 wnsgur1 requested a review from 8954sood June 12, 2024 04:50
Copy link
Member

@8954sood 8954sood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@8954sood 8954sood merged commit 753237c into develop Jun 12, 2024
1 check passed
@8954sood 8954sood deleted the feature/94-create-email-sign-in branch June 12, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 새로운 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Email SignIn
2 participants