Extend --strip test to expose a failure #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some oddities with incremental backups where --strip or --strip-path were involved with 'bup save'. This change extends the 'strip' test by doing two gratuitous index/save cycles after the initial save, which ends up with the latest version of the backup being empty and thus exposes a bug.
It seems to me that the problem is somewhere around lines 234--248 of cmd/save-cmd.py, where after mangling the directory using --strip, --strip-path or --graft the original 'ent' is used to validate trees, but my understanding of that part of the code isn't sufficient to allow me a quick fix.