chore: support new switchover action #1338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 69 69
Lines 6685 6700 +15
=====================================
- Misses 6685 6700 +15 ☔ View full report in Codecov by Sentry. |
cjc7373
requested review from
kizuna-lek,
leon-inf,
Y-Rookie,
a team,
ldming,
1aal,
xuriwuyun and
free6om
as code owners
leon-inf
reviewed
Dec 26, 2024
| /tools/syncerctl switchover --primary "$KB_LEADER_POD_NAME" ${KB_SWITCHOVER_CANDIDATE_NAME:+--candidate "$KB_SWITCHOVER_CANDIDATE_NAME"} | ||
| if [ -z "$KB_SWITCHOVER_ROLE" ]; then | ||
| echo "role can't be empty" | ||
| exit 1 |
There was a problem hiding this comment.
The KB_SWITCHOVER_ROLE might be empty by design, but a non-zero exit indicates that the switchover action execution failed.
There was a problem hiding this comment.
I think in most cases we can rely on kb's role info. Engines who need more precise role info can later change to a way that gets role info directly from kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: apecloud/kubeblocks#8645