Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small observer can't join quorum, so need use getView() #2211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zichen-gan
Copy link

ZK BUG Like QuorumAuthObserverTest#testSmallObserverJoinSASLQuorum
When SASL Quorum like:
server.11=localhost:11223:11224:participant
server.21=localhost:11226:11227:participant
server.1=localhost:11229:11230:observer

The server.1 can't join quorum.

@anmolnar
Copy link
Contributor

anmolnar commented Nov 5, 2024

Thanks @zichen-gan for taking care of this. Could you please create a jira ticket first?

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix patch makes sense to me at first glance, but what does 'small' mean in this context? One with smaller identifier?

@zichen-gan
Copy link
Author

zichen-gan commented Nov 6, 2024

jira zk is full of users, so I can't mention it anymore. I'd be very grateful if you could help me mention one.

@anmolnar yes, small myid observer can't join sasl quorum.

@zichen-gan
Copy link
Author

Because zk always takes the initiative to connect myid with a larger myid.And startConnection() only authenticate when peer is voting, so observer can't join quorum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants