-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:Configurable summarySetBlackList to set monitoring blacklist. #2165
base: master
Are you sure you want to change the base?
Conversation
/** | ||
* Base implementation of {@link MetricsProvider}.<br> | ||
* 提供默认的实现,当前包含summarySet黑名单功能。 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use English, instead of Chinese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
I cannot understand the intention of this PR clearly. From the description, I guess
|
it wants to solve metrics(write_per_namespace,read_per_namespace) which is too expensive.
|
Perhaps it's a more universal and maintainable solution to remove the metric monitoring when the / path node is deleted. Regarding this PR, I will make some further modifications. |
Yes, I understand now. When you frequently create and delete numerous znodes at the first level, the write_per_namespace and read_per_namespace metrics will indeed expand and consume excessive memory. A possible workaround is to add an additional layer under the root directory of the tree (e.g., /taskName/taskId-[1,n]). While deleting the SummarySet key might work, it seems somewhat counterintuitive. Here are a few alternative suggestions (just my personal opinion):
|
I am the ZK cluster provider, so it is difficult for businesses to modify the way they use it.😂 The reason why i don't want to use blacklists is that each business that developer them incorrectly needs to configure a blacklist.So i deleting the SummarySet key to make ZK developer unconsciously. I'm sorry, I don't understand why this is counterintuitive. @maoling |
Issue:
Root Cause:
Solution:
Provide a new version of the ZK server that supports configurable Namespace monitoring.