Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4795: add namespace support for prometheus metrics #2119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZOOKEEPER-4795: add namespace support for prometheus metrics #2119

wants to merge 1 commit into from
+57 −0

Conversation

purushah
Copy link
Contributor

No description provided.

eolivelli
eolivelli reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen this feature enabled in other projects that use Prometheus, like Pulsar, BookKeeper, Cassandra....

Usually if you can configure the scape configuration to add labels to the metrics coming from a pod/service.

is this a best practice ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purushah @eolivelli