[ZEPPELIN-5962] LivyInterpreter support more parameter when create session #4657
Conversation
| } | ||
|
|
||
| public String toJson() { | ||
| return gson.toJson(this); | ||
| JsonObject jsonObject = new JsonObject(); |
There was a problem hiding this comment.
You might miss import statement for JsonObject?
|
@zhaomoran Hello, thank you for your contribution. I left a comment and could you please add test cases? I read your ticket and looks fine but I think it would be better to have a test for this case. |
|
@jongyoul OK，I just presented the idea here. If the community thinks it's a good idea, I'll add test cases to it. |
|
I believe that your contribution must help others. :-) |
|
Please perform a rebase. I have recently migrated the tests to JUnit5. Currently there are merge conflicts. |
|
@jongyoul This is my first time submitting a PR. Is there anything else I need to do? |
|
@zhaomoran The last step is making all CI green. We have some flaky tests but I usually try to execute some failed tests again to make it green. Your contribution itself is proper to be merged. Could you please wait for a while until the CI becomes green? |
|
@zhaomoran Thank you for your first contribution. I hope you contribute more and more. I merged your PR and assigned you with the JIRA ticket as well. |
…ssion (apache#4657) * LivyInterpreter support more parameter when create session * Add test for ZEPPELIN-5962 --------- Co-authored-by: mrzhao <[email protected]>
What is this PR for?
LivyInterpreter support more parameter when create session
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: