Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2923] Fix invalid routerLink setting in header breadcrumb #211

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Fixed invalid routerLink setting in header breadcrumb
When click header bearcrumb will navigate to '#/crumb.url' currently.

What type of PR is it?

  • - Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2923

Screenshots (if appropriate)

Before After
bandicam.2024-10-14.19-36-43-230.mp4
bandicam.2024-10-14.19-37-28-422.mp4

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (20f66e5) to head (a887f1a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   38.77%   35.71%   -3.07%     
==========================================
  Files           2        2              
  Lines          49       56       +7     
==========================================
+ Hits           19       20       +1     
- Misses         27       33       +6     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@craigcondit craigcondit changed the title [YUNIKORN-2923] Fixed invalid routerLink setting in header breadcrumb [YUNIKORN-2923] Fix invalid routerLink setting in header breadcrumb Oct 17, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2923 branch November 2, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants