[YUNIKORN-2913] Fix contrast issue in Applications view #210
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 38.77% 35.71% -3.07%
==========================================
Files 2 2
Lines 49 56 +7
==========================================
+ Hits 19 20 +1
- Misses 27 33 +6
Partials 3 3 ☔ View full report in Codecov by Sentry. |
craigcondit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR resolves the issue in the applications view. When an application is selected in the table, there is a low contrast issue where resources are not visible.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2913
How should this be tested?
It might be hard to notice, but on strange windows sizing that will allow you to notice resources behind the sidebar. The other way is to disable the sidebar (or misconfigure the module federation plugin - set remote entry and component to some random strings in env)
Screenshots (if appropriate)
Before:
Fixed:
