Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2897] Health checker reports foreign allocation as orphan #977

Closed
wants to merge 2 commits into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 2, 2024

What is this PR for?

Helath checker is broken after YUNIKORN-2832, because a foreign allocation is incorrectly reported as orphan.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2897

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (a2d3d43) to head (359738b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   81.50%   81.52%   +0.01%     
==========================================
  Files          97       97              
  Lines       12632    12625       -7     
==========================================
- Hits        10296    10292       -4     
+ Misses       2054     2051       -3     
  Partials      282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as draft October 3, 2024 12:22
@pbacsko
Copy link
Contributor Author

pbacsko commented Oct 3, 2024

Removing GetAllAllocations() because the semantics has changed and it's misleading. Let's have GetYunikornAllocations() and GetForeignAllocations().

@pbacsko pbacsko marked this pull request as ready for review October 3, 2024 12:48
@pbacsko pbacsko closed this in 4ea2251 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants