Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2862] Improve nodesorting test coverage #967

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve the following funtion's test coverage

  • absResourceUsage (zero weight & shares resource value NaN case)
  • cloneWeights
  • ResourceWeights
  • ResourceWeights
  • NewNodeSortingPolicy (SortingPolicy default case unreachable case)

What type of PR is it?

  • - Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2862

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (6f06490) to head (f662ac3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   80.84%   80.96%   +0.12%     
==========================================
  Files          97       97              
  Lines       12512    12509       -3     
==========================================
+ Hits        10115    10128      +13     
+ Misses       2126     2112      -14     
+ Partials      271      269       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@craigcondit craigcondit changed the title [UNIKORN-2862] Improve nodesorting funtion's test coverage [YUNIKORN-2862] Improve nodesorting test coverage Sep 9, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2862 branch September 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants