Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2120] Fix incorrect error message when check maxApplications in configValidator #693

Closed
wants to merge 1 commit into from

Conversation

brandboat
Copy link
Member

What is this PR for?

The error message use terms maxRunningApps when setup incorrect maxapplications in ConfigMap. Would be more explicit if we replace maxRunningApps with maxApplications.

error: configmaps "yunikorn-configs" could not be patched: admission webhook "admission-webhook.yunikorn.validate-conf" denied the request: parent maxRunningApps must be larger than child maxRunningApps

What type of PR is it?

  • - Improvement

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2120

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks!

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #693 (3b63001) into master (d1fe998) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files          80       80           
  Lines       13263    13263           
=======================================
  Hits        10295    10295           
  Misses       2648     2648           
  Partials      320      320           
Files Coverage Δ
pkg/common/configs/configvalidator.go 93.23% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@brandboat brandboat deleted the YUNIKORN-2120 branch November 4, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants