code review

apache · Sep 10, 2024 · c884e64 · c884e64
1 parent 15a7abd
commit c884e64
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/pkg/webservice/handlers_test.go b/pkg/webservice/handlers_test.go
@@ -1744,12 +1744,7 @@ func TestGetApplicationHandler(t *testing.T) {
 	assert.Equal(t, appsDao.ApplicationID, "app-1")
 	assert.Equal(t, appsDao.Partition, "default")
 	assert.Equal(t, appsDao.QueueName, "root.default")
-
-	if !appsDao.HasReserved {
-		assert.Equal(t, len(appsDao.Reservations), 0)
-	} else {
-		assert.Check(t, len(appsDao.Reservations) > 0, "app should have at least 1 reservation")
-	}
+	assert.Equal(t, len(appsDao.Allocations), 0)
 
 	// test nonexistent partition
 	var req1 *http.Request
@@ -1788,11 +1783,7 @@ func TestGetApplicationHandler(t *testing.T) {
 	assert.Equal(t, appsDao4.ApplicationID, "app-1")
 	assert.Equal(t, appsDao4.Partition, "default")
 	assert.Equal(t, appsDao4.QueueName, "root.default")
-	if !appsDao4.HasReserved {
-		assert.Equal(t, len(appsDao4.Reservations), 0)
-	} else {
-		assert.Check(t, len(appsDao4.Reservations) > 0, "app should have at least 1 reservation")
-	}
+	assert.Equal(t, len(appsDao4.Reservations), 0)
 
 	// test invalid queue name
 	var req5 *http.Request