Fix up relative runbook links

apache · Feb 9, 2024 · a0c5d2e · a0c5d2e
1 parent 465f96b
commit a0c5d2e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/whimsy/asf/meeting-util.rb b/lib/whimsy/asf/meeting-util.rb
@@ -13,6 +13,8 @@ class MeetingUtil
     VCAL_EVENTS_FILENAME = 'ASF-members-meeting.ics'
     PROXIES_FILENAME = 'proxies'
 
+    # The URL is generated using emit_link() in meeting.cgi
+    # if the name includes '/' then use as is unless it starts with 'runbook/'
     MEETING_FILES = { # Filename in meeting dir, pathname to another deployed tool, or URL
       'README.txt' => 'README For Meeting Process And Roll Call',
       'runbook/email_03_nomination_of_board.txt' => 'How To Nominate Someone For Board',

diff --git a/www/members/meeting.cgi b/www/members/meeting.cgi
@@ -25,7 +25,7 @@ end
 
 # Utility function for links, Note: cheezy path detection within MEETING_FILES
 def emit_link(cur_mtg_dir, f, desc)
-  _a desc, href: f.include?('/') ? f : File.join(cur_mtg_dir, f)
+  _a desc, href: f.include?('/') && !f.start_with?('runbook/') ? f : File.join(cur_mtg_dir, f)
 end
 
 # Output action links for meeting records, depending on if current or past