UNOMI-861: use asynchronous delete_by_query in migration scripts to a… #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsinovassin
force-pushed
the
UNOMI-861
branch
from
ee94556 to
48331e6
Compare
dgriffon
approved these changes
Oct 24, 2024
| startUnomi(); | ||
| } | ||
| } catch (Exception e) { | ||
| LOGGER.error("Error while starting Unomi", e); |
There was a problem hiding this comment.
This seems to catch more than a starting Unomi exception.
jsinovassin
force-pushed
the
UNOMI-861
branch
from
dc2e2a4 to
08a6eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…void timeout
https://issues.apache.org/jira/browse/UNOMI-861
Following the update done in #697
In the migration steps, the delete_by_query and update_by_query has been update to execute an asynchronous call in order to avoid to reach a timeout if the request takes too long.
A try catch has also been added in the the Activate method of UnomiManagementServiceImpl because when there was a fail, the Activate method was called again