UNOMI-858: Fix CodeQL Java Error + Fix code scanning alert no. 11: Insecure randomness #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jsinovassin
force-pushed
the
alert-autofix-11
branch
from
d723b1a to
615bc5a
Compare
jsinovassin
changed the title
jsinovassin
force-pushed
the
alert-autofix-11
branch
from
615bc5a to
9a5fb6c
Compare
jsinovassin
changed the title
dgriffon
approved these changes
Oct 14, 2024
jayblanc
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/UNOMI-858
Specify the Java version to use in the CodeQL workflow
Fixes https://github.com/apache/unomi/security/code-scanning/11
To fix the problem, we need to replace the use of
Math.random()with a cryptographically secure random number generator. In the browser environment,crypto.getRandomValuesis the recommended method. This function generates cryptographically secure random values, which can be used to replace the insecureMath.random().Math.random()call withcrypto.getRandomValues.generateUUIDfunction in thesamples/tweet-button-plugin/src/main/webapp/index.htmlfile.Suggested fixes powered by Copilot Autofix. Review carefully before merging.